Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logic to ensure that watch indices exist before test starts #66416

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Add logic to ensure that watch indices exist before test starts #66416

merged 1 commit into from
Dec 16, 2020

Conversation

jbaiera
Copy link
Member

@jbaiera jbaiera commented Dec 15, 2020

This PR updates the initialization logic in TransportMonitoringMigrateAlertsActionTests to wait for the watch indices separately from the rest of the initialization logic in order to allow for the .watches index to be available before the test begins.

relates #66391

@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Dec 15, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

probakowski
probakowski approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@probakowski probakowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jbaiera

@jbaiera jbaiera merged commit 937627d into elastic:master Dec 16, 2020
@jbaiera jbaiera deleted the ci-migrate-monitoring-watches-initfix branch December 16, 2020 00:02
@jbaiera jbaiera mentioned this pull request Dec 16, 2020
Merged
jbaiera added a commit that referenced this pull request Dec 16, 2020
@jbaiera
Add extra steps to ensure that watch indices are created before test …
a074cf9 
…starts (#66416) (#66422)

This PR updates the initialization logic in TransportMonitoringMigrateAlertsActionTests to wait
for the watch indices separately from the rest of the initialization logic in order to allow for the
.watches index to be available before the test begins.
@jbaiera jbaiera mentioned this pull request Dec 16, 2020
Merged
jbaiera added a commit that referenced this pull request Dec 16, 2020
@jbaiera
Add extra steps to ensure that watch indices are created before test …
ac5cfb5 
…starts (#66416) (#66422) (#66466)

This PR updates the initialization logic in TransportMonitoringMigrateAlertsActionTests to wait
for the watch indices separately from the rest of the initialization logic in order to allow for the
.watches index to be available before the test begins.
This was referenced Dec 18, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@probakowski probakowski probakowski approved these changes

Assignees
No one assigned
Labels
:Data Management/Monitoring >non-issue Team:Data Management Meta label for data/management team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbaiera @elasticmachine @probakowski