Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Log4J config example in docs #66386

Merged

Conversation

DaveCTurner
Copy link
Contributor

We lost the logger.transport.name line in #65169 and I incorrectly
extrapolated from what was left and mangled it further in #66318. This
commit fixes things.

We lost the `logger.transport.name` line in elastic#65169 and I incorrectly
extrapolated from what was left and mangled it further in elastic#66318. This
commit fixes things.
@DaveCTurner DaveCTurner added >docs General docs changes :Core/Infra/Logging Log management and logging utilities v8.0.0 v7.11.0 v7.10.2 labels Dec 15, 2020
@DaveCTurner DaveCTurner requested a review from jrodewig December 15, 2020 17:29
@elasticmachine elasticmachine added Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team labels Dec 15, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for correcting this @DaveCTurner.

@DaveCTurner DaveCTurner merged commit 32b20fd into elastic:master Dec 15, 2020
@DaveCTurner DaveCTurner deleted the 2020-12-15-fix-log4j-config-example branch December 15, 2020 17:42
DaveCTurner added a commit that referenced this pull request Dec 15, 2020
We lost the `logger.transport.name` line in #65169 and I incorrectly
extrapolated from what was left and mangled it further in #66318. This
commit fixes things.
DaveCTurner added a commit that referenced this pull request Dec 15, 2020
We lost the `logger.transport.name` line in #65169 and I incorrectly
extrapolated from what was left and mangled it further in #66318. This
commit fixes things.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Logging Log management and logging utilities >docs General docs changes Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team v7.10.2 v7.11.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants