Use the build JVM for executing third party audit checks #66379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-delivery (Team:Delivery) |
mark-vieira
added a commit
that referenced
this pull request
Dec 15, 2020
(cherry picked from commit 87fafc7)
mark-vieira
added a commit
that referenced
this pull request
Dec 15, 2020
)" This reverts commit 31d944a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not be using the runtime java home for build-time precommit checks. These things have no relevance to runtime java, which should only be used for changing the JVM when executing Elasticsearch code (i.e. tests), not build code. This also causes issues which certain tools because now the available classpath changes based on build environment which we don't want.
This pull request removes the last usage of runtime java home for build checks and instead we use the current Gradle JVM.