Searchable snapshot rolling restart #66369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new setting `xpack.searchable.snapshot.allocation.enable.primaries` that indicates the behavior of searchable snapshots when the generic `cluster.routing.allocation.enable` setting is set to `primaries`. Valid values are NONE and PRIMARIES (defer to generic decider). Defaults to NONE since this ensures existing rolling restart procedures do not reallocate searchable snapshot shards to other nodes.
henningandersen
added
>enhancement
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
reviewed
Dec 15, 2020
| internalCluster().restartNode(indexNode); | ||
| } | ||
|
|
||
| assertBusy(() -> { |
There was a problem hiding this comment.
I think we don't need to assertBusy() here, if this fails even once then that's a fail.
| * | ||
| */ | ||
| public static final Setting<EnableAllocationDecider.Allocation> SEARCHABLE_SNAPSHOTS_ALLOCATION_ENABLE_PRIMARIES_SETTING = | ||
| new Setting<>("xpack.searchable.snapshot.allocation.enable.primaries", EnableAllocationDecider.Allocation.NONE.toString(), |
There was a problem hiding this comment.
Hmm this means we have these options:
xpack.searchable.snapshot.allocation.enable.primaries: none
xpack.searchable.snapshot.allocation.enable.primaries: primaries
The repetition of primaries seems odd to me. I see that this is a bit nicer than a straight boolean, given the relationship to the other allocation decider, but how about these options instead?
xpack.searchable.snapshot.allocation.enable: none
xpack.searchable.snapshot.allocation.enable: all
There was a problem hiding this comment.
I misunderstood the precise meaning of this setting, sorry, it defaults to none!
We discussed this in another channel and decided a boolean called xpack.searchable.snapshot.allocate_on_rolling_restart which defaults to false.
| primariesAllocation | ||
| ); | ||
| } else { | ||
| return allocation.decision(Decision.YES, NAME, "decider relies on generic enable decider"); |
There was a problem hiding this comment.
I think this message is wrong, the decider return YES here because xpack.searchable.snapshot.allocation.enable.primaries: primaries permits it.
|
Thanks David. |
henningandersen
added a commit
that referenced
this pull request
Dec 15, 2020
Add a new boolean setting `xpack.searchable.snapshot.allocate_on_rolling_restart` that indicates the behavior of searchable snapshots when the generic `cluster.routing.allocation.enable` setting is set to `primaries`. Defaults to false, meaning that when `cluster.routing.allocation.enable=primaries`, searchable snapshots are not allocated.This ensures existing rolling restart procedures do not reallocate searchable snapshot shards to other nodes.
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Oct 7, 2024
…art` setting The setting was created as an escape-hatch in case elastic#66369 had some unintended side-effects. It has been deprecated since elastic#84959 (8.2.0).
arteam
added a commit
that referenced
this pull request
Nov 14, 2024
…art` setting (#114202) The setting was created as an escape-hatch in case #66369 had some unintended side-effects. It has been deprecated since #84959 (8.2.0). --------- Co-authored-by: David Turner <[email protected]>
salvatore-campagna
pushed a commit
to salvatore-campagna/elasticsearch
that referenced
this pull request
Nov 18, 2024
…art` setting (elastic#114202) The setting was created as an escape-hatch in case elastic#66369 had some unintended side-effects. It has been deprecated since elastic#84959 (8.2.0). --------- Co-authored-by: David Turner <[email protected]>
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
…art` setting (elastic#114202) The setting was created as an escape-hatch in case elastic#66369 had some unintended side-effects. It has been deprecated since elastic#84959 (8.2.0). --------- Co-authored-by: David Turner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new boolean setting
xpack.searchable.snapshot.allocate_on_rolling_restartthat indicates the behavior of searchable snapshots when the generic
cluster.routing.allocation.enablesetting is set toprimaries.Defaults to false, meaning that when
cluster.routing.allocation.enable=primaries,searchable snapshots are not allocated.This ensures existing rolling restart procedures
do not reallocate searchable snapshot shards to other nodes.