Remove Lucene Precommit from PersistentCache (#66324) #66331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is nothing gained from doing the precommit step explicitly here. Also, we can just reuse the same map entries statically.
original-brownbear
added
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
requested changes
Dec 15, 2020
There was a problem hiding this comment.
Repeating my comment on the master issue here:
Hang on, this is deliberate and meaningful. We precommit on all the data paths first to try and surface a failure before we get to the commit step. Failure at the precommit stage is nonfatal, but failure at the commit stage will terminate the node.
Please don't merge this!
DaveCTurner
approved these changes
Dec 15, 2020
|
npnp thanks for keeping an eye on my Shenanigans :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is nothing gained from doing the precommit step explicitly here.
Also, we can just reuse the same map entries statically.
backport of #66324