Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Added docs for aggregate_metric_double field #66306

Merged
merged 18 commits into from
Dec 15, 2020
Merged

[DOCS] Added docs for aggregate_metric_double field #66306

merged 18 commits into from
Dec 15, 2020

Conversation

csoulios
Copy link
Contributor

Added documentation for the aggregate_metric_double field that was merged in #56745

@csoulios csoulios added >docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types v8.0.0 v7.11.0 labels Dec 14, 2020
@csoulios csoulios requested review from talevy and jrodewig December 14, 2020 21:55
@elasticmachine elasticmachine added Team:Search Meta label for search team Team:Docs Meta label for docs team labels Dec 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

jrodewig
jrodewig approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me overall. I left some suggestions, but nothing I would consider blocking.

I thinking adding a section for mapping parameter reference would be helpful.

docs/reference/mapping/types/aggregate-metric-double.asciidoc Outdated Show resolved Hide resolved
docs/reference/mapping/types/aggregate-metric-double.asciidoc Outdated Show resolved Hide resolved
docs/reference/mapping/types/aggregate-metric-double.asciidoc Outdated Show resolved Hide resolved
docs/reference/mapping/types/aggregate-metric-double.asciidoc Outdated Show resolved Hide resolved
docs/reference/mapping/types/aggregate-metric-double.asciidoc Outdated Show resolved Hide resolved
docs/reference/mapping/types/aggregate-metric-double.asciidoc Outdated Show resolved Hide resolved
docs/reference/mapping/types/aggregate-metric-double.asciidoc Outdated Show resolved Hide resolved
docs/reference/mapping/types/aggregate-metric-double.asciidoc Outdated Show resolved Hide resolved
docs/reference/mapping/types/aggregate-metric-double.asciidoc Outdated Show resolved Hide resolved
docs/reference/mapping/types/aggregate-metric-double.asciidoc Outdated Show resolved Hide resolved
csoulios and others added 14 commits December 15, 2020 18:54
@csoulios @jrodewig
Update docs/reference/mapping/types/aggregate-metric-double.asciidoc
b5aa79f 
Co-authored-by: James Rodewig <[email protected]>
@csoulios @jrodewig
Update docs/reference/mapping/types/aggregate-metric-double.asciidoc
e5dc168 
Co-authored-by: James Rodewig <[email protected]>
@csoulios @jrodewig
Update docs/reference/mapping/types/aggregate-metric-double.asciidoc
6821379 
Co-authored-by: James Rodewig <[email protected]>
@csoulios @jrodewig
Update docs/reference/mapping/types/aggregate-metric-double.asciidoc
131d032 
Co-authored-by: James Rodewig <[email protected]>
@csoulios @jrodewig
Update docs/reference/mapping/types/aggregate-metric-double.asciidoc
4b46291 
Co-authored-by: James Rodewig <[email protected]>
@csoulios @jrodewig
Update docs/reference/mapping/types/aggregate-metric-double.asciidoc
38ced72 
Co-authored-by: James Rodewig <[email protected]>
@csoulios @jrodewig
Update docs/reference/mapping/types/aggregate-metric-double.asciidoc
52a5213 
Co-authored-by: James Rodewig <[email protected]>
@csoulios @jrodewig
Update docs/reference/mapping/types/aggregate-metric-double.asciidoc
c782266 
Co-authored-by: James Rodewig <[email protected]>
@csoulios @jrodewig
Update docs/reference/mapping/types/aggregate-metric-double.asciidoc
e617471 
Co-authored-by: James Rodewig <[email protected]>
@csoulios @jrodewig
Update docs/reference/mapping/types/aggregate-metric-double.asciidoc
866fde2 
Co-authored-by: James Rodewig <[email protected]>
@csoulios @jrodewig
Update docs/reference/mapping/types/aggregate-metric-double.asciidoc
814cb9b 
Co-authored-by: James Rodewig <[email protected]>
@csoulios @jrodewig
Update docs/reference/mapping/types/aggregate-metric-double.asciidoc
03384ee 
Co-authored-by: James Rodewig <[email protected]>
@csoulios @jrodewig
Update docs/reference/mapping/types/aggregate-metric-double.asciidoc
813b5b1 
Co-authored-by: James Rodewig <[email protected]>
@csoulios
Addressing reviewer comments
828d9c6
@csoulios csoulios merged commit 30efc2b into elastic:master Dec 15, 2020
@csoulios csoulios deleted the aggregate_metric_doc_master branch December 15, 2020 17:27
@csoulios csoulios mentioned this pull request Dec 15, 2020
Merged
@jrodewig jrodewig mentioned this pull request Dec 15, 2020
Merged
@csoulios csoulios mentioned this pull request Dec 15, 2020
Merged
csoulios added a commit that referenced this pull request Dec 15, 2020
@csoulios @jrodewig
[7.x] [DOCS] Added docs for aggregate_metric_double field (#66306) (#…
f4c92ae 
…66388)

Added documentation for the aggregate_metric_double field that was merged in #56745

Co-authored-by: James Rodewig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrodewig jrodewig jrodewig approved these changes

@talevy talevy Awaiting requested review from talevy

Assignees
No one assigned
Labels
>docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Docs Meta label for docs team Team:Search Meta label for search team v7.11.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@csoulios @elasticmachine @jrodewig @jakelandis