Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Note tar.gz does not include systemd #66298

Merged
merged 2 commits into from
Dec 15, 2020
Merged

[DOCS] Note tar.gz does not include systemd #66298

merged 2 commits into from
Dec 15, 2020

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Dec 14, 2020

@jrodewig jrodewig added >docs General docs changes :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts v8.0.0 v7.11.0 v7.10.2 v7.12.0 labels Dec 14, 2020
@jrodewig jrodewig marked this pull request as ready for review December 14, 2020 20:09
@elasticmachine elasticmachine added Team:Delivery Meta label for Delivery team Team:Docs Meta label for docs team labels Dec 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@jrodewig jrodewig requested a review from jasontedor December 14, 2020 20:09
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up, I left a few suggestions. No need for another round, I trust your judgement on these suggestions.

@@ -21,5 +21,6 @@ To shut down Elasticsearch, kill the process ID recorded in the `pid` file:
pkill -F pid
--------------------------------------------

NOTE: The startup scripts provided in the <<rpm,RPM>> and <<deb,Debian>>
packages take care of starting and stopping the Elasticsearch process for you.
NOTE: {es}'s `.tar.gz` package do not include `systemd`. To automatically start
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "The {es} .tar.gz package does not", to avoid the possessive, and "systemd module", adding "module". And instead of "To automatically start {es} when the system boots up" -> "To manage Elasticsearch as a service"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Thanks for the suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts >docs General docs changes Team:Delivery Meta label for Delivery team Team:Docs Meta label for docs team v7.10.2 v7.11.0 v7.12.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elasticsearch iNotify not being sent to systemctl / systemd
4 participants