[Transform] Handle multi-fields properly when creating destination index. #66273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml/Transform) |
przemekwitek
commented
Dec 15, 2020
...in/transform/src/main/java/org/elasticsearch/xpack/transform/persistence/TransformIndex.java
Outdated
Show resolved
Hide resolved
|
run elasticsearch-ci/default-distro |
przemekwitek
force-pushed
the
latest_fix_multi_field
branch
from
13ea108 to
5dca6cd
Compare
hendrikmuhs
approved these changes
Dec 15, 2020
...in/transform/src/main/java/org/elasticsearch/xpack/transform/persistence/TransformIndex.java
Outdated
Show resolved
Hide resolved
…estination index mappings
Simplify "diveInto" method by using "computeIfAbsent"
przemekwitek
force-pushed
the
latest_fix_multi_field
branch
from
5dca6cd to
141e1fb
Compare
przemekwitek
added a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Dec 16, 2020
przemekwitek
added a commit
that referenced
this pull request
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When source index contained a text & keyword field
foo, creation of the destination index finished with error:This PR solves the problem by producing a proper mapping for a multi-field before creating the destination index.
Relates #65869
Marking
>non-issueas this fix is for an unreleased feature.