Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EQL: [Tests] New eql correctness data snapshot #66238

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

matriv
Copy link
Contributor

@matriv matriv commented Dec 14, 2020

With the upcoming validation for type compatibility of the sequence
keys, several tests are failing because some fields that contain IP
data were previously mapped as keyword. Fixed the mapping and created a
new snapshot of the correctness data in the gcs bucket.

Relates to: #66183

With the upcoming validation for type compatibility of the sequence
keys, several tests are failing because some fields that contain IP
data were previously mapped as keyword. Fixed the mapping and created a
new snaphost of the correctness data in the gcs bucket.

Relates to: elastic#66183
@matriv matriv added >test Issues or PRs that are addressing/adding tests v8.0.0 :Analytics/EQL EQL querying v7.11.0 v7.10.2 labels Dec 14, 2020
@matriv matriv requested a review from costin December 14, 2020 00:14
@elasticmachine elasticmachine added the Team:QL (Deprecated) Meta label for query languages team label Dec 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@costin costin merged commit 7f638f6 into elastic:master Dec 14, 2020
@matriv matriv deleted the new-eql-correctness-snap branch December 14, 2020 09:31
matriv added a commit that referenced this pull request Dec 14, 2020
With the upcoming validation for type compatibility of the sequence
keys, several tests are failing because some fields that contain IP
data were previously mapped as keyword. Fixed the mapping and created a
new snaphost of the correctness data in the gcs bucket.

Relates to: #66183

(cherry picked from commit 7f638f6)
matriv added a commit that referenced this pull request Dec 14, 2020
With the upcoming validation for type compatibility of the sequence
keys, several tests are failing because some fields that contain IP
data were previously mapped as keyword. Fixed the mapping and created a
new snaphost of the correctness data in the gcs bucket.

Relates to: #66183

(cherry picked from commit 7f638f6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/EQL EQL querying Team:QL (Deprecated) Meta label for query languages team >test Issues or PRs that are addressing/adding tests v7.10.2 v7.11.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants