Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Add copy_from parameter for set ingest processor (#63540) #66202

Merged
merged 2 commits into from
Dec 11, 2020

Conversation

danhermann
Copy link
Contributor

Relates to #55682 and #51046, and refractor the code of #56985.

The main point of this PR is adding a copy_from parameter for set ingest processor to support copy the value of one field to another. We can copy boolean, number, array, object and other data types by the parameter copy_from instead of using template snippet which only produces string value.

Why adding a new parameter to implement the copy function but not modifying the template snippet so that it can produce object or array value ? I think we can make it compatible with older versions, users can still use template snippet to copy the produced string value to other field, but also can use copy_from to copy object or array value from one field to another.

The main changes are:

  1. Add copy_from parameter for set ingest processor.
  2. Add unit test and yml test for the change.
  3. Update the set processor's document.

Backport of #63540

@danhermann danhermann added >enhancement :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP backport v7.11.0 labels Dec 11, 2020
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Dec 11, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

@danhermann danhermann merged commit 11dd465 into elastic:7.x Dec 11, 2020
@danhermann danhermann deleted the backport_7x_63540_set_copy_from branch December 11, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >enhancement Team:Data Management Meta label for data/management team v7.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants