Fix failure in fvh REST tests related to hit order #66192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In general, we can't guarantee that a match_all query will return documents in the order they were indexed. This PR adds an ID to each document to avoid relying on document order.
jtibshirani
added
:Search Relevance/Highlighting
|
Pinging @elastic/es-search (Team:Search) |
jtibshirani
changed the title
mayya-sharipova
approved these changes
Dec 15, 2020
jtibshirani
added a commit
that referenced
this pull request
Dec 15, 2020
In general, we can't guarantee that a match_all query will return documents in the order they were indexed. This PR adds an ID to each document to avoid relying on document order.
jtibshirani
added a commit
that referenced
this pull request
Dec 15, 2020
In general, we can't guarantee that a match_all query will return documents in the order they were indexed. This PR adds an ID to each document to avoid relying on document order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, we can't guarantee that a match_all query will return documents in
the order they were indexed. This PR adds an ID to each document to avoid
relying on document order.
Fixes #66147.