Show -Dlicense.key value in test repro info #66179
Conversation
breskeby
added
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
| @@ -181,10 +182,32 @@ private ReproduceErrorMessageBuilder appendESProperties() { | |||
| appendOpt("tests.timezone", TimeZone.getDefault().getID()); | |||
| appendOpt("tests.distribution", System.getProperty("tests.distribution")); | |||
| appendOpt("runtime.java", Integer.toString(JavaVersion.current().getVersion().get(0))); | |||
| appendOpt("runtime.java", Integer.toString(JavaVersion.current().getVersion().get(0))); | |||
There was a problem hiding this comment.
This line seems to be duplicated?
| appendOpt(ESTestCase.FIPS_SYSPROP, System.getProperty(ESTestCase.FIPS_SYSPROP)); | ||
| return this; | ||
| } | ||
|
|
||
| private String relativePath(String pathProperty) { |
There was a problem hiding this comment.
Is this necessary once the fix is made in xpack to use Gradle's file resolution to get the path relative to the root project? With that change, and using a relative path in CI, shouldn't the reproduction line should just work for devs copying it from CI to their machines?
There was a problem hiding this comment.
This also works with having an absolute path passed in the commandline (e.g.on ci)
There was a problem hiding this comment.
But it will not required if we ensure we always pass a relative path here only
There was a problem hiding this comment.
I'm just wondering if is necessary at all. It is specifically for CI. If a developer passes an absolute path, it will still work. We just need to ensure we pass a relative path in CI.
There was a problem hiding this comment.
in that case I can remove this
- When a -Dlicense.key sys property is passed to the build we want to consider this in the test reproduction info message - absolute Paths tried to be converted to relative paths relative to workspace root to allow simply copy & paste - Also fixes a inconsistency for checking license existence in x-pack plugin core build
breskeby
force-pushed
the
consider-license-sysprop-in-repro-printer
branch
from
85ce4ce to
70a72aa
Compare
- When a -Dlicense.key sys property is passed to the build we want to consider this in the test reproduction info message - Absolute Paths tried to be converted to relative paths relative to workspace root to allow simply copy & paste - Also fixes a inconsistency for checking license existence in x-pack plugin core build
- When a -Dlicense.key sys property is passed to the build we want to consider this in the test reproduction info message - Absolute Paths tried to be converted to relative paths relative to workspace root to allow simply copy & paste - Also fixes a inconsistency for checking license existence in x-pack plugin core build
- When a -Dlicense.key sys property is passed to the build we want to consider this in the test reproduction info message - Absolute Paths tried to be converted to relative paths relative to workspace root to allow simply copy & paste - Also fixes a inconsistency for checking license existence in x-pack plugin core build
this in the test reproduction info message
root to allow simply copy & paste