Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transform] add hlrc integration tests for get and getStats #66177

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

hendrikmuhs
Copy link

@hendrikmuhs hendrikmuhs commented Dec 10, 2020

add hlrc integration tests for get and getStats

closes #43052

(fixes the oldest transform issue ;-) )

@hendrikmuhs hendrikmuhs added >test Issues or PRs that are addressing/adding tests v8.0.0 :ml/Transform Transform v7.11.0 labels Dec 10, 2020
@dimitris-athanasiou
Copy link
Contributor

Code looks good. I think the PR description shouldn't state that it fixes #43052 as this commit only adds tests that guard the fix.

I also have a small concern whether the test is slow. How long does it take? If it's too long, perhaps we can put fewer transforms while still having more than 100.

@hendrikmuhs
Copy link
Author

Code looks good. I think the PR description shouldn't state that it fixes #43052 as this commit only adds tests that guard the fix.

will change it to closes, the fix is #62809, but did not wanted to close the issue without verification.

I also have a small concern whether the test is slow. How long does it take? If it's too long, perhaps we can put fewer transforms while still having more than 100.

I tested it, it seemed ok, arguable it will take longer on CI than on my dev machine. It runs in parallel to other tests and seems not to make the build taking longer.

Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hendrikmuhs hendrikmuhs merged commit 40addd3 into elastic:master Dec 15, 2020
@hendrikmuhs hendrikmuhs deleted the transform-get-hlrc-testing branch December 15, 2020 08:50
hendrikmuhs pushed a commit that referenced this pull request Dec 15, 2020
add hlrc integration tests for get and getStats

closes #43052
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml/Transform Transform >test Issues or PRs that are addressing/adding tests v7.11.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] GET _transform only returns 100
3 participants