Extend dynamic templates to make them define runtime fields (#66112) #66156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…66112) Runtime fields are defined as part of the runtime section in the mappings. Dynamic templates allow to specify mappings for fields that are getting automatically created. With this change, we allow users to create dynamic under the runtime section, and optionally define their mappings. The following is an example of dynamic template that matches any incoming long field as runtime field, meaning they will all be evaluated at runtime. When a script is not specified, runtime fields are loaded from a field with the same name in _source. ``` { "mappings": { "dynamic_templates": [ { "long_as_runtime": { "match_mapping_type": "long", "runtime": { } } } ] } } ```
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Dec 10, 2020
As part of elastic#66156 the validation of dynamic templates has been adapted to support runtime fields. As part of that change, a `break` was forgotten, which causes needless additional validation rounds after a template has been already successfully validated against one of the field types.
|
run elasticsearch-ci/bwc |
javanna
added a commit
that referenced
this pull request
Dec 10, 2020
As part of #66156 the validation of dynamic templates has been adapted to support runtime fields. As part of that change, a `break` was forgotten, which causes needless additional validation rounds after a template has been already successfully validated against one of the field types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime fields are defined as part of the runtime section in the mappings. Dynamic templates allow to specify mappings for fields that are getting automatically created. With this change, we allow users to create dynamic under the runtime section, and optionally define their mappings.
The following is an example of dynamic template that matches any incoming long field as runtime field, meaning they will all be evaluated at runtime. When a script is not specified, runtime fields are loaded from a field with the same name in _source.
Backport of #66112