[Transform] randomize integration tests using runtime fields #66148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendrikmuhs
added
>test
|
Pinging @elastic/ml-core (:ml/Transform) |
przemekwitek
approved these changes
Dec 14, 2020
| new GroupConfig.Builder().groupBy("event", new TermsGroupSource.Builder().setField("event").setMissingBucket(missing).build()) | ||
| .build() | ||
| new GroupConfig.Builder().groupBy( | ||
| "event", |
There was a problem hiding this comment.
Shouldn't this be termsField?
There was a problem hiding this comment.
no, this is the output field name, on the next line there is setField(termsField)
Having that said, it would be more understandable if input and output use different names
hendrikmuhs
pushed a commit
that referenced
this pull request
Dec 14, 2020
this change adds coverage for runtime fields to the continuous transform integration test cases. runtime fields are configured at random.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change adds coverage for runtime fields to the continuous transform integration test cases. runtime fields are configured at random.
Note: I haven't changed integration tests for latest, because of the ongoing fields API rewrite.