Clean up some aggregation tests (backport of #66044) #66134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rewrites two tests for aggregations to use `AggregatorTestCase`'s simpler way of making `Aggregator`s, allowing us to remove a ctor on `ProductionAggregationContext` that we weren't happy about. Now there is only a single test call to `ProductionAggregationContext` and we can remove that soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrites two tests for aggregations to use
AggregatorTestCase'ssimpler way of making
Aggregators, allowing us to remove a ctor onProductionAggregationContextthat we weren't happy about. Now there isonly a single test call to
ProductionAggregationContextand we canremove that soon.