Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Fix repetitive timeout query params in delete-by-query and update-by-query doc #66075

Merged
merged 2 commits into from
Dec 9, 2020
Merged

[DOCS] Fix repetitive timeout query params in delete-by-query and update-by-query doc #66075

merged 2 commits into from
Dec 9, 2020

Conversation

gaobinlong
Copy link
Contributor

There are two timeout query paramters in the delete-by-query doc and update-by-query doc, which is confused.

After checking the code, I found that the first timeout means search_timeout actually. Both the two timeout reference the parameters in the common-params doc, so they are repetitive.

elasticsearch/modules/reindex/src/main/java/org/elasticsearch/index/reindex/AbstractBulkByQueryRestHandler.java

Line 66 in 07aec1b

if (restRequest.hasParam("search_timeout")) {

jrodewig
jrodewig approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this @gaobinlong.

@jrodewig
Copy link
Contributor

jrodewig commented Dec 9, 2020

@elasticmachine ok to test

@jrodewig jrodewig added :Distributed Indexing/Reindex Issues relating to reindex that are not caused by issues further down >docs General docs changes v7.10.2 v7.11.0 v8.0.0 labels Dec 9, 2020
@elasticmachine elasticmachine added Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Team:Docs Meta label for docs team labels Dec 9, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@jrodewig jrodewig merged commit 424ceb1 into elastic:master Dec 9, 2020
This was referenced Dec 9, 2020
Merged
Merged
jrodewig added a commit that referenced this pull request Dec 9, 2020
@jrodewig @gaobinlong
[DOCS] Fix search_timeout parameter docs (#66075) (#66125)
5e90709 
Co-authored-by: James Rodewig <[email protected]>

Co-authored-by: bellengao <[email protected]>
jrodewig added a commit that referenced this pull request Dec 9, 2020
@jrodewig @gaobinlong
[DOCS] Fix search_timeout parameter docs (#66075) (#66126)
30f1f5c 
Co-authored-by: James Rodewig <[email protected]>

Co-authored-by: bellengao <[email protected]>
@gaobinlong gaobinlong deleted the fix_docs branch December 21, 2020 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrodewig jrodewig jrodewig approved these changes

Assignees
No one assigned
Labels
:Distributed Indexing/Reindex Issues relating to reindex that are not caused by issues further down >docs General docs changes Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Team:Docs Meta label for docs team v7.10.2 v7.11.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaobinlong @jrodewig @elasticmachine @jakelandis