Fix eclipse compilation #66047
Merged
Fix eclipse compilation #66047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like we've hit another "funny" eclipse compiler error. I filed https://bugs.eclipse.org/bugs/show_bug.cgi?id=569557 , but short version is that the following code compiles with javac and not eclipse: ``` package test; import java.util.function.Supplier; public class Test { private final Object o = new Object(); private class Inner { public Inner() { this(() -> o); } private Inner(Supplier<Object> o) {} } } ``` Specifically the outer class's `o` can't be refered to in the lambda. This stops us from doing that in ML so eclipse can be happy again.
|
Pinging @elastic/ml-core (:ml) |
cbuescher
reviewed
Dec 8, 2020
benwtrent
approved these changes
Dec 8, 2020
|
Thanks for reviews folks! |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Dec 8, 2020
Looks like we've hit another "funny" eclipse compiler error. I filed https://bugs.eclipse.org/bugs/show_bug.cgi?id=569557 , but short version is that the following code compiles with javac and not eclipse: ``` package test; import java.util.function.Supplier; public class Test { private final Object o = new Object(); private class Inner { public Inner() { this(() -> o); } private Inner(Supplier<Object> o) {} } } ``` Specifically the outer class's `o` can't be refered to in the lambda. This stops us from doing that in ML so eclipse can be happy again.
nik9000
added a commit
that referenced
this pull request
Dec 8, 2020
Looks like we've hit another "funny" eclipse compiler error. I filed https://bugs.eclipse.org/bugs/show_bug.cgi?id=569557 , but short version is that the following code compiles with javac and not eclipse: ``` package test; import java.util.function.Supplier; public class Test { private final Object o = new Object(); private class Inner { public Inner() { this(() -> o); } private Inner(Supplier<Object> o) {} } } ``` Specifically the outer class's `o` can't be refered to in the lambda. This stops us from doing that in ML so eclipse can be happy again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we've hit another "funny" eclipse compiler error. I filed
https://bugs.eclipse.org/bugs/show_bug.cgi?id=569557 , but short version
is that the following code compiles with javac and not eclipse:
Specifically the outer class's
ocan't be refered to in the lambda.This stops us from doing that in ML so eclipse can be happy again.