Add some more tests for source-only fields #66030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romseygeek
added
>test
|
Pinging @elastic/es-search (Team:Search) |
javanna
approved these changes
Dec 9, 2020
There was a problem hiding this comment.
LGTM thanks @romseygeek shall we add yaml tests for querying nested docs also?
romseygeek
added a commit
that referenced
this pull request
Dec 14, 2020
This commit adds some more test coverage for runtime fields: * source-only field tests now use dynamic:false instead of defining disabled object fields * new tests for source-only fields defined at query time * tests for shadowing of nested fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds some more test coverage for runtime fields:
object fields