Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: Enable the InnerAggregates inside PIVOT (#65792) #65987

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

palesz
Copy link
Contributor

@palesz palesz commented Dec 7, 2020

  • Remove the limitation of not being able to use InnerAggregate
    inside PIVOTs (aggregations using extended and matrix stats)
  • The limitation was introduced as part of the original PIVOT
    implementation in SQL: Add PIVOT support #46489, but after Refactor named expression 3 #49693 it could be lifted.
  • Test that the PIVOT results in the same query as the
    GROUP BY. This should hold across all the
    AggregateFunctions we have.

(cherry-picked from 67704b0)

* Remove the limitation of not being able to use `InnerAggregate`
inside PIVOTs (aggregations using extended and matrix stats)
* The limitation was introduced as part of the original `PIVOT`
implementation in elastic#46489, but after elastic#49693 it could be lifted.
* Test that the `PIVOT` results in the same query as the
`GROUP BY`. This should hold across all the
`AggregateFunction`s we have.
(cherry-pick 67704b0)
@palesz palesz added >feature :Analytics/SQL SQL querying backport Team:QL (Deprecated) Meta label for query languages team v7.11.0 labels Dec 7, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@palesz palesz merged commit 4197126 into elastic:7.x Dec 7, 2020
@palesz palesz deleted the feature/pivot-inneraggregates-7.x branch December 7, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/SQL SQL querying backport >feature Team:QL (Deprecated) Meta label for query languages team v7.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants