Avoid tasks materialized during configuration phase #65922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breskeby
added
:Delivery/Build
|
@elasticmachine test this please |
|
@elasticmachine update branch please |
|
merge conflict between base and head |
breskeby
force-pushed
the
avoid-task-creation-during-config-phase
branch
2 times, most recently
from
ec6b8a2 to
f559603
Compare
pugnascotia
reviewed
Dec 9, 2020
gradle.properties
Outdated
| @@ -7,7 +7,7 @@ org.gradle.jvmargs=-XX:+HeapDumpOnOutOfMemoryError -Xss2m | |||
| systemProp.org.gradle.dependency.duplicate.project.detection=false | |||
|
|
|||
| # Enforce the build to fail on deprecated gradle api usage | |||
| systemProp.org.gradle.warning.mode=fail | |||
| # systemProp.org.gradle.warning.mode=fail | |||
There was a problem hiding this comment.
Is this change intentional?
There was a problem hiding this comment.
nope. good catch. fixed
pugnascotia
approved these changes
Dec 9, 2020
breskeby
force-pushed
the
avoid-task-creation-during-config-phase
branch
from
c08a4e3 to
5217d45
Compare
|
@elasticmachine update branch |
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Dec 12, 2020
* Avoid tasks materialized during configuration phase * Fix RestTestFromSnippet testRoot setup
breskeby
added a commit
that referenced
this pull request
Dec 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework more build scripts to make usage of task avoidance api and avoid
unnecessary task creations across the build to reduce overall configuration overhead.
Another major benefit we gain from this is that we now also avoid unnecessary
test cluster creation and configuration as these are by default only created
when the according integTest or consumer task is created when requested for execution
This brings us another step closer to finish off #56610