Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push build scan configuration into background #65806

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Push build scan configuration into background #65806

merged 1 commit into from
Dec 4, 2020

Conversation

breskeby
Copy link
Contributor

@breskeby breskeby commented Dec 3, 2020

  • Build scans allow to be configured in a background thread which lowers the impact
    of the configuration on the overall build configuration time.
  • The configuration time was already quite low but as its such a low hanging fruit we
    take advantage of that option in our ES build too.

@breskeby
Push build scan configuration into background
410443f 
- Build scans allow to be configured in a background thread which lowers the impact
of the configuration on the overall build configuration time.
- The configuration time was already quite low but as its such a low hanging fruit we
take advantage of that option in our ES build too.
@breskeby breskeby self-assigned this Dec 3, 2020
@breskeby breskeby added :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v7.11.0 v8.0.0 labels Dec 3, 2020
@breskeby breskeby marked this pull request as ready for review December 3, 2020 10:40
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@breskeby breskeby requested a review from mark-vieira December 4, 2020 11:33
mark-vieira
mark-vieira approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, since we don't do anything computationally expensive here I wonder if the added overhead of spawning a thread is a net loss? Either way, it's probably not even measurable.

@breskeby
Copy link
Contributor Author

breskeby commented Dec 4, 2020

@mark-vieira I did some microbenchmarks with this and saw a small improvement and definitely no net loss

@breskeby breskeby merged commit 197e3ec into elastic:master Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-vieira mark-vieira mark-vieira approved these changes

Assignees

@breskeby breskeby

Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v7.11.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@breskeby @elasticmachine @mark-vieira @jakelandis