Fix composite aggregation on unsigned long #65715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures that the after key is parsed with the doc value formatter. This is needed for unsigned longs that uses shifted longs internally. Closes elastic#65685
jimczi
added
>bug
:Analytics/Geo
elasticmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
mayya-sharipova
approved these changes
Dec 14, 2020
There was a problem hiding this comment.
@jimczi LGTM. Sorry for a delayed review, I missed this PR. Thanks for fixing this issue.
jimczi
added a commit
that referenced
this pull request
Dec 14, 2020
This commit ensures that the after key is parsed with the doc value formatter. This is needed for unsigned longs that uses shifted longs internally. Closes #65685
jimczi
added a commit
that referenced
this pull request
Dec 14, 2020
This commit ensures that the after key is parsed with the doc value formatter. This is needed for unsigned longs that uses shifted longs internally. Closes #65685
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that the after key is parsed with the doc value formatter.
This is needed for unsigned longs that uses shifted longs internally.
Closes #65685