Use ValueFetcher when loading text snippets to highlight (#63572) #65441
Conversation
HighlighterUtils.loadFieldValues() loads values directly from the source, and then callers have to deal with filtering out values that would have been removed by an ignore_above filter on keyword fields. Instead, we can use the ValueFetcher for the relevant field, which handles all this logic for us. Closes elastic#59931.
|
cc @jtibshirani - I've added a new |
|
|
||
| See also <<release-highlights>> and <<es-release-notes>>. | ||
|
|
||
| // * <<breaking_710_blah_changes>> |
There was a problem hiding this comment.
breaking_710_blah_changes -> breaking_711_blah_changes
| //tag::notable-breaking-changes[] | ||
|
|
||
| [discrete] | ||
| [[breaking_710_search_changes]] |
There was a problem hiding this comment.
breaking_710_search_changes -> breaking_711_search_changes
| === Search changes | ||
|
|
||
| [[highlight-normalization]] | ||
| .Keyword fields with a custom normalizer will use the normalized form when highlighting |
There was a problem hiding this comment.
Should we mention the change to copy_to as well? This is technically a breaking behavioral change, and it's nice to alert users about it because they could be able to stopping setting store: true on some fields.
|
I've fixed the 710->711 substitutions that I'd missed earlier. I'm don't think this is the right place to call out the |
Sounds good to me! |
|
@elasticmachine update branch |
HighlighterUtils.loadFieldValues() loads values directly from the source, and
then callers have to deal with filtering out values that would have been removed
by an ignore_above filter on keyword fields. Instead, we can use the
ValueFetcher for the relevant field, which handles all this logic for us.
Closes #59931.