Fix watcher search template test after #65332 #65379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In elastic#65332, the serialization of the WatcherSearchTemplateRequest class changed to use IndicesOptions built in XContent facilities. This had the side effect of fixing the handling of `all` for `expand_wildcards` to include hidden indices. However, the tests in WatcherUtilsTests were missed. This change updates those tests.
jaymode
added
>test
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-core-features (Team:Core/Features) |
jaymode
added a commit
to jaymode/elasticsearch
that referenced
this pull request
Nov 23, 2020
In elastic#65332, the serialization of the WatcherSearchTemplateRequest class changed to use IndicesOptions built in XContent facilities. This had the side effect of fixing the handling of `all` for `expand_wildcards` to include hidden indices. However, the tests in WatcherUtilsTests were missed. This change updates those tests. Backport of elastic#65379
This was referenced Nov 23, 2020
|
@elasticmachine update branch |
martijnvg
approved these changes
Nov 24, 2020
jaymode
added a commit
that referenced
this pull request
Nov 24, 2020
In #65332, the serialization of the WatcherSearchTemplateRequest class changed to use IndicesOptions built in XContent facilities. This had the side effect of fixing the handling of `all` for `expand_wildcards` to include hidden indices. However, the tests in WatcherUtilsTests were missed. This change updates those tests. Backport of #65379
jaymode
added a commit
that referenced
this pull request
Nov 24, 2020
In #65332, the serialization of the WatcherSearchTemplateRequest class changed to use IndicesOptions built in XContent facilities. This had the side effect of fixing the handling of `all` for `expand_wildcards` to include hidden indices. However, the tests in WatcherUtilsTests were missed. This change updates those tests. Backport of #65379
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #65332, the serialization of the WatcherSearchTemplateRequest class
changed to use IndicesOptions built in XContent facilities. This had
the side effect of fixing the handling of
allforexpand_wildcardsto include hidden indices. However, the tests in WatcherUtilsTests were
missed. This change updates those tests.