QL: Introduce common analyzer base class #65325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract the analyzer base classes into a common project similar to the Optimizer ones. Extract AddMissingEqualsOnBoolFields a common rule to be used across Close elastic#63695
costin
added
>enhancement
:Analytics/SQL
elasticmachine
added
the
Team:QL (Deprecated)
|
Pinging @elastic/es-ql (Team:QL) |
costin
commented
Nov 21, 2020
| @@ -38,7 +38,7 @@ SELECT TRUNCATE(YEAR(TODAY() - INTERVAL 50 YEARS) / 1000) AS result; | |||
|
|
|||
|
|
|||
| currentDateFilter | |||
| SELECT first_name FROM test_emp WHERE hire_date > CURRENT_DATE() - INTERVAL 35 YEARS ORDER BY first_name ASC LIMIT 10; | |||
| SELECT first_name FROM test_emp WHERE hire_date > CURRENT_DATE() - INTERVAL 44 YEARS ORDER BY first_name ASC LIMIT 10; | |||
There was a problem hiding this comment.
Just as it happens an entry in the dataset failed this condition today (21/11/1985) - I've updated the filter to remain the same for another 9 years :)
bpintea
approved these changes
Nov 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract the analyzer base classes into a common project similar to the
Optimizer ones.
Extract AddMissingEqualsOnBoolFields a common rule to be used across
Close #63695