Makes testCcrRepositoryFetchesSnapshotShardSizeFromIndexShardStoreStats more robust #64976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>test
|
Pinging @elastic/es-distributed (:Distributed/CCR) |
elasticmachine
added
the
Team:Distributed (Obsolete)
original-brownbear
approved these changes
Nov 12, 2020
x-pack/plugin/ccr/src/internalClusterTest/java/org/elasticsearch/xpack/ccr/CcrRepositoryIT.java
Show resolved
Hide resolved
x-pack/plugin/ccr/src/internalClusterTest/java/org/elasticsearch/xpack/ccr/CcrRepositoryIT.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/ccr/src/internalClusterTest/java/org/elasticsearch/xpack/ccr/CcrRepositoryIT.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/ccr/src/internalClusterTest/java/org/elasticsearch/xpack/ccr/CcrRepositoryIT.java
Show resolved
Hide resolved
|
Thanks Armin! |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Nov 12, 2020
…ts more robust (elastic#64976) Today this test fails because the sizes of the snapshot shards are only kept in a very short period of time in the InternalSnapshotsInfoService and are not guaranteed to exist once the shards are correctly assigned. closes elastic#64167
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Nov 12, 2020
…ts more robust (elastic#64976) Today this test fails because the sizes of the snapshot shards are only kept in a very short period of time in the InternalSnapshotsInfoService and are not guaranteed to exist once the shards are correctly assigned. closes elastic#64167
This was referenced Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today this test fails because the sizes of the snapshot shards are only kept in a very short period of time in the
InternalSnapshotsInfoServiceand are not guaranteed to exist once the shards are correctly assigned.This test implements a suggestion from Armin to make the test both simpler and less prone to failures.
closes #64167