Remove deprecated _upgrade API #64732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danhermann
added
>breaking
:Data Management/Indices APIs
|
Pinging @elastic/es-core-features (:Core/Features/Indices APIs) |
danhermann
commented
Nov 6, 2020
Comment on lines
+184
to
+185
| registerTaskManagerListeners(ForceMergeAction.NAME); // main task | ||
| registerTaskManagerListeners(ForceMergeAction.NAME + "[n]"); // node level tasks |
There was a problem hiding this comment.
Replaced with a different index action so tasks are still tested
Comment on lines
-321
to
-322
| public void upgradeIndexSettings(final UpgradeSettingsClusterStateUpdateRequest request, | ||
| final ActionListener<AcknowledgedResponse> listener) { |
There was a problem hiding this comment.
Did not appear to be called outside of the _upgrade API.
| /** | ||
| * Upgrades the shard to the current version of Lucene and returns the minimum segment version | ||
| */ | ||
| public org.apache.lucene.util.Version upgrade(UpgradeRequest upgrade) throws IOException { |
There was a problem hiding this comment.
Did not appear to be called outside of the _upgrade API.
pgomulka
added a commit
that referenced
this pull request
Jul 9, 2021
…75136) indices upgrade api (/_upgrade or /{index}/_upgrade) was removed and _reindex is suggested to be used instead. There is no easy way to translate _upgrade request to _reindex requests. The dummy Upgrade action will return an exception to a user with a message indicating that _reindex should be used. upgrade api removal #64732 relates #51816
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_upgradeAPI has been superseded by the_reindexAPI and was deprecated in 7.11.0. This commit removes it completely for the 8.0.0 release.Resolves #21337