-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: fix testMoveToStepRereadsPolicy flakiness #64466
Merged
andreidan
merged 1 commit into
elastic:master
from
andreidan:fix-testMoveToStepRereadsPolicy
Nov 4, 2020
Merged
Tests: fix testMoveToStepRereadsPolicy flakiness #64466
andreidan
merged 1 commit into
elastic:master
from
andreidan:fix-testMoveToStepRereadsPolicy
Nov 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testMoveToStepRereadsPolicy relied on an updated ILM policy that had a rollover condition that enabled the index to be rolled after one second. This changes the test to use a `max_doc`:1 condition so it's under the test's control to trigger the condition.
andreidan
added
>test
Issues or PRs that are addressing/adding tests
:Data Management/ILM+SLM
Index and Snapshot lifecycle management
v8.0.0
v7.10.0
v7.11.0
labels
Nov 2, 2020
Pinging @elastic/es-core-features (:Core/Features/ILM+SLM) |
dakrone
approved these changes
Nov 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Andrei!
andreidan
added a commit
to andreidan/elasticsearch
that referenced
this pull request
Nov 4, 2020
testMoveToStepRereadsPolicy relied on an updated ILM policy that had a rollover condition that enabled the index to be rolled after one second. This changes the test to use a `max_doc`:1 condition so it's under the test's control to trigger the condition. (cherry picked from commit 73ab35a) Signed-off-by: Andrei Dan <[email protected]>
andreidan
added a commit
that referenced
this pull request
Nov 4, 2020
testMoveToStepRereadsPolicy relied on an updated ILM policy that had a rollover condition that enabled the index to be rolled after one second. This changes the test to use a `max_doc`:1 condition so it's under the test's control to trigger the condition. (cherry picked from commit 73ab35a) Signed-off-by: Andrei Dan <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
andreidan
added a commit
to andreidan/elasticsearch
that referenced
this pull request
Nov 4, 2020
testMoveToStepRereadsPolicy relied on an updated ILM policy that had a rollover condition that enabled the index to be rolled after one second. This changes the test to use a `max_doc`:1 condition so it's under the test's control to trigger the condition. (cherry picked from commit 73ab35a) Signed-off-by: Andrei Dan <[email protected]>
andreidan
added a commit
that referenced
this pull request
Nov 4, 2020
testMoveToStepRereadsPolicy relied on an updated ILM policy that had a rollover condition that enabled the index to be rolled after one second. This changes the test to use a `max_doc`:1 condition so it's under the test's control to trigger the condition. (cherry picked from commit 73ab35a) Signed-off-by: Andrei Dan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Data Management/ILM+SLM
Index and Snapshot lifecycle management
Team:Data Management
Meta label for data/management team
>test
Issues or PRs that are addressing/adding tests
v7.10.0
v7.11.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testMoveToStepRereadsPolicy relied on an updated ILM policy that had
a rollover condition that enabled the index to be rolled after one second.
This changes the test to use a
max_doc
:1 condition so it's under thetest's control to trigger the condition.
Fixes #53612