Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Clarify field data cache behavior #64375
[DOCS] Clarify field data cache behavior #64375
Changes from 1 commit
7430993
57411de
391ab35
c121d75
87e148a
784de58
b83b080
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small comments to make the language more precise:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really small comment, the link text is usually just the parameter name: <<copy-to, `copy_to`>>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized that it's not possible to use
copy_to
with the_id
mapper, so this only works for custom IDs where the user can manually duplicate the ID into another field.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I'll clarify that, that wasn't clear in the original text. Going to move this entire section to the top.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we soon plan to entirely remove the ability to sort/ aggregate on
_id
, I think it'd be best not to mention the cluster setting. It mostly just helps with the 7.x -> 8.x upgrade.It looks like we forgot to mention
_id
field data in the 8.0 breaking changes docs though. I can fix that in a follow-up.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are actually still discussing this recommendation in #59829, perhaps we could hold off on adding this sentence until we have a conclusion.
Also maybe "Aggregations that include high cardinality values" -> "Aggregations on high cardinality fields" ?
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not actually sure it's a significant contributor to heap usage, since only one
join
mapping is allowed per index? But it's helpful to know that it produces field data, maybe we could just say "It can also trigger <<eager-global-ordinals, global ordinals>> to be built."There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this consolidation, it makes it clear this description only applies to
text
.