Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle degenerated rectangles while indexing #64122

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

iverase
Copy link
Contributor

@iverase iverase commented Oct 26, 2020

We currently generate invalid polygons if a rectangle is degenerated. This commit handles those cases by generating lines or points when necessary.

@iverase iverase added >bug :Analytics/Geo Indexing, search aggregations of geo points and shapes v8.0.0 v7.11.0 labels Oct 26, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Geo)

@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Oct 26, 2020
Copy link
Contributor

@csoulios csoulios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iverase iverase merged commit 266f52d into elastic:master Oct 27, 2020
@iverase iverase deleted the degeneratedRectangles branch October 27, 2020 11:44
iverase added a commit that referenced this pull request Oct 27, 2020
We currently generate invalid polygons if a rectangle is degenerated. This commit handles those cases by generating lines or points when necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v7.11.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants