Add a test for regex usage to runtime fields #63951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we've got regexes enabled by default (elastic#63029) this adds a test to runtime fields just to make sure that it works with regexes. It does, but this adds a test to make sure it continues to work.
nik9000
added
>test
|
Pinging @elastic/es-search (:Search/Search) |
javanna
reviewed
Oct 20, 2020
| Matcher m = /([^ ]+) .+/.matcher(doc["message"].value); | ||
| if (m.matches()) { | ||
| emit(m.group(1)); | ||
| } |
There was a problem hiding this comment.
out of curiosity, what happens when matches returns false for a doc? the runtime field wont have any value thats it?
javanna
approved these changes
Oct 20, 2020
|
Yup. No value.
…On Tue, Oct 20, 2020, 14:46 Luca Cavanna ***@***.***> wrote:
***@***.**** approved this pull request.
thanks @nik9000 <https://github.com/nik9000>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#63951 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABUXIRIZGMDTOEQXKRS2PTSLXLINANCNFSM4SYUG6GA>
.
|
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Oct 20, 2020
Now that we've got regexes enabled by default (elastic#63029) this adds a test to runtime fields just to make sure that it works with regexes. It does, but this adds a test to make sure it continues to work.
nik9000
added a commit
that referenced
this pull request
Oct 20, 2020
pugnascotia
pushed a commit
to pugnascotia/elasticsearch
that referenced
this pull request
Oct 21, 2020
Now that we've got regexes enabled by default (elastic#63029) this adds a test to runtime fields just to make sure that it works with regexes. It does, but this adds a test to make sure it continues to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we've got regexes enabled by default (#63029) this adds a test
to runtime fields just to make sure that it works with regexes. It does,
but this adds a test to make sure it continues to work.