Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark the search 'fields' option as beta. #63699

Merged
merged 1 commit into from
Oct 17, 2020

Conversation

jtibshirani
Copy link
Contributor

@jtibshirani jtibshirani commented Oct 14, 2020

We've identified two important enhancements that may affect the API:

We expect any API changes from these enhancements to be minor, but want to leave open the possibility for small breaks. For example, we may end up returning unmapped fields by default, or omitting nested fields from the root hit. The impact to users should be quite small.

We're tracking the issues we need to resolve before removing the 'beta' label here: #60985.

@jtibshirani jtibshirani added >docs General docs changes :Search/Search Search-related issues that do not fall into other categories v8.0.0 v7.10.0 v7.11.0 labels Oct 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Search Meta label for search team labels Oct 14, 2020
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! Hopefully we won't end up breaking the API to handle those issues but it is important that we have the option if we need it. And we have a plan for removing this - once we've got those two issues handled we can remove this.

@jtibshirani jtibshirani merged commit a98fd8b into elastic:master Oct 17, 2020
@jtibshirani jtibshirani deleted the fields-beta branch October 17, 2020 00:13
@jtibshirani
Copy link
Contributor Author

Thanks @nik9000 !

jtibshirani added a commit that referenced this pull request Oct 18, 2020
We've identified two important enhancements that may affect the API. We expect
any API changes from these enhancements to be minor, but want to leave open the
possibility for small breaks. For example, we may end up returning unmapped
fields by default, or omitting nested fields from the root hit. The impact to
users should be quite small.

We're tracking the issues we need to resolve before removing the 'beta' label
here: #60985.
jtibshirani added a commit that referenced this pull request Oct 18, 2020
We've identified two important enhancements that may affect the API. We expect
any API changes from these enhancements to be minor, but want to leave open the
possibility for small breaks. For example, we may end up returning unmapped
fields by default, or omitting nested fields from the root hit. The impact to
users should be quite small.

We're tracking the issues we need to resolve before removing the 'beta' label
here: #60985.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Search/Search Search-related issues that do not fall into other categories Team:Docs Meta label for docs team Team:Search Meta label for search team v7.10.0 v7.11.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants