Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes week_year date format #63384

Merged
merged 2 commits into from
Oct 12, 2020
Merged

Removes week_year date format #63384

merged 2 commits into from
Oct 12, 2020

Conversation

pgomulka
Copy link
Contributor

@pgomulka pgomulka commented Oct 7, 2020

week_year is replaced by weekyear. This is a single field YYYY date
format.
follow up after a deprecation #63307
relates #60707

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@pgomulka
Removes week_year date format
ad6eb70 
week_year is replaced by weekyear. This is a single field YYYY date
format.

relates elastic#60707
@pgomulka pgomulka added :Core/Infra/Core Core issues without another label v8.0.0 labels Oct 7, 2020
@pgomulka pgomulka requested review from russcam and rjernst October 7, 2020 07:39
@pgomulka pgomulka self-assigned this Oct 7, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Core)

@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Oct 7, 2020
This was referenced Oct 7, 2020
Closed
Closed
rjernst
rjernst approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgomulka pgomulka merged commit 15a2a35 into elastic:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjernst rjernst rjernst approved these changes

@russcam russcam Awaiting requested review from russcam

Assignees
No one assigned
Labels
>breaking :Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgomulka @elasticmachine @rjernst @jakelandis