Fix XContentTypeTests where version was a negative byte #63382

pgomulka · 2020-10-07T06:55:29Z

a random byte could be -128 and when used with Math.abs it would result
in an int 128. That in turn when casting back to byte would overflow and
result in -128 again.
Fixed with a randomNonNegativeByte method

closes #63342

Have you signed the contributor license agreement?
Have you followed the contributor guidelines?
If submitting code, have you built your formula locally prior to submission with gradle check?
If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
If submitting code, have you checked that your submission is for an OS and architecture that we support?
If you are submitting this code for a class then read our policy for that.

a random byte could be -128 and when used with Math.abs it would result in an int 128. That in turn when casting back to byte would overflow and result in -128 again. Fixed with a randomNonNegativeByte method closes elastic#63342

elasticmachine · 2020-10-07T06:55:31Z

Pinging @elastic/es-core-infra (:Core/Infra/Core)

rjernst

LGTM

rjernst · 2020-10-07T16:40:39Z

test/framework/src/main/java/org/elasticsearch/test/ESTestCase.java

@@ -607,6 +607,11 @@ public static byte randomByte() {
        return (byte) random().nextInt();
    }

+    public static byte randomNonNegativeByte() {
+        byte randomByte =  (byte) random().nextInt();


nit: just use randomByte()?

imotov

LGTM. Thanks!

Fix XContentTypeTests where version was a negative byte

d2a85d2

a random byte could be -128 and when used with Math.abs it would result in an int 128. That in turn when casting back to byte would overflow and result in -128 again. Fixed with a randomNonNegativeByte method closes elastic#63342

pgomulka added :Core/Infra/Core Core issues without another label >test-failure Triaged test failures from CI labels Oct 7, 2020

pgomulka self-assigned this Oct 7, 2020

elasticmachine added the Team:Core/Infra Meta label for core/infra team label Oct 7, 2020

pgomulka requested a review from imotov October 7, 2020 16:20

rjernst approved these changes Oct 7, 2020

View reviewed changes

imotov approved these changes Oct 7, 2020

View reviewed changes

pgomulka added 2 commits October 8, 2020 08:49

use rnadomByte()

be07feb

Merge branch 'master' into test/fix_negative_byte

1459519

pgomulka merged commit 9b056e1 into elastic:master Oct 8, 2020

ChrisHegarty unassigned pgomulka Oct 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix XContentTypeTests where version was a negative byte #63382

Fix XContentTypeTests where version was a negative byte #63382

pgomulka commented Oct 7, 2020

elasticmachine commented Oct 7, 2020

rjernst left a comment

rjernst Oct 7, 2020

imotov left a comment

Fix XContentTypeTests where version was a negative byte #63382

Fix XContentTypeTests where version was a negative byte #63382

Conversation

pgomulka commented Oct 7, 2020

elasticmachine commented Oct 7, 2020

rjernst left a comment

Choose a reason for hiding this comment

rjernst Oct 7, 2020

Choose a reason for hiding this comment

imotov left a comment

Choose a reason for hiding this comment