Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Rounding range query rules #63109

Merged
merged 9 commits into from
Oct 2, 2020

Conversation

pgomulka
Copy link
Contributor

@pgomulka pgomulka commented Oct 1, 2020

I added this in range query seciton, but maybe it should be in date math section?
https://elasticsearch_63109.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/common-options.html#date-math
relates #62268

@pgomulka pgomulka added >docs General docs changes :Core/Infra/Core Core issues without another label labels Oct 1, 2020
@pgomulka pgomulka self-assigned this Oct 1, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Core)

@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Core/Infra Meta label for core/infra team labels Oct 1, 2020
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I relocated your section and added some xrefs. I also removed an outdated warning as we discussed.

Thanks for taking care of this.

@jrodewig
Copy link
Contributor

jrodewig commented Oct 1, 2020

On second thought, I decided to leave this on the range query page as its really dealing with date values provided in a query or aggregation rather than date fields.

@pgomulka
Copy link
Contributor Author

pgomulka commented Oct 2, 2020

wow! that really looks good now. Thanks @jrodewig for this.

@pgomulka pgomulka merged commit b38eaae into elastic:master Oct 2, 2020
pgomulka added a commit to pgomulka/elasticsearch that referenced this pull request Oct 2, 2020
a documentation explaining defaulting of missing fields when using date math parser.
relates elastic#62268
pgomulka added a commit to pgomulka/elasticsearch that referenced this pull request Oct 2, 2020
a documentation explaining defaulting of missing fields when using date math parser.
relates elastic#62268
pgomulka added a commit that referenced this pull request Oct 2, 2020
a documentation explaining defaulting of missing fields when using date math parser.
relates #62268
pgomulka added a commit that referenced this pull request Oct 2, 2020
a documentation explaining defaulting of missing fields when using date math parser.
relates #62268
pgomulka added a commit to pgomulka/elasticsearch that referenced this pull request Feb 10, 2022
a documentation explaining defaulting of missing fields when using date math parser.
relates elastic#62268
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label >docs General docs changes Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team v7.10.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants