Make sure that IdFieldType#isAggregatable is accurate. #62903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtibshirani
force-pushed
the
field-caps-id
branch
from
f2d3083 to
4240bd2
Compare
Before, it always returned 'true' even when the setting "indices.id_field_data.enabled" was false.
jtibshirani
force-pushed
the
field-caps-id
branch
from
4240bd2 to
bdb4f8b
Compare
|
@elasticmachine run elasticsearch-ci/2 |
jtibshirani
commented
Sep 25, 2020
| throw new IllegalArgumentException("Fielddata access on the _id field is disallowed, " | ||
| + "you can re-enable it by updating the dynamic cluster setting: " | ||
| + IndicesService.INDICES_ID_FIELD_DATA_ENABLED_SETTING.getKey()); | ||
| } | ||
| deprecationLogger.deprecate("id_field_data", ID_FIELD_DATA_DEPRECATION_MESSAGE); |
There was a problem hiding this comment.
I kept the deprecation message here so we don't issue a warning on every call to field caps.
jimczi
added
:Search Foundations/Mapping
|
Pinging @elastic/es-search (:Search/Mapping) |
|
The refactor #63197 was merged concurrently, and happens to fix the bug. So after merging with master, this PR is now a test-only change that verifies the fix. |
|
@elasticmachine run elasticsearch-ci/1 |
jtibshirani
added a commit
that referenced
this pull request
Oct 6, 2020
Before, it always returned 'true' even when the setting "indices.id_field_data.enabled" was false. Fixes #62897.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, it always returned 'true' even when the setting
"indices.id_field_data.enabled" was false.
Fixes #62897.