[ML] Set parent task Id on ml expired data removers #62854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml) |
przemekwitek
approved these changes
Sep 24, 2020
| this.parentTaskId = parentTaskId; | ||
| } | ||
|
|
||
| protected TaskId getParentTaskId() { |
There was a problem hiding this comment.
I'm wondering if it would make sense for this method to be a part of the MlDataRemover interface.
davidkyle
added a commit
to davidkyle/elasticsearch
that referenced
this pull request
Sep 28, 2020
Setting the parent task Id (of the delete expired data action) on the ML expired data removers makes it easier to track and cancel long running tasks # Conflicts: # x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/job/retention/ExpiredForecastsRemover.java # x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/job/retention/ExpiredModelSnapshotsRemover.java
davidkyle
added a commit
that referenced
this pull request
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the parent task Id (of the delete expired data action) on the expired data removers.
This makes it easier to track and cancel long running tasks
The data removers all use
OriginSettingClientwhich I couldn't replace for aParentTaskAssigningClientso the parent id had to be added to each request. The only other option I could think of is to create aOriginSettingParentTaskAssigningClientclass.