Add case insensitive prefix and wildcard to 'version' field #62754
Conversation
cbuescher
added
>enhancement
:Search Foundations/Mapping
|
Pinging @elastic/es-search (:Search/Mapping) |
|
@markharwood would you mind taking a look since you worked on the case insensitivity option lately? |
| } | ||
|
|
||
| protected static Automaton toCaseInsensitiveChar(int codepoint, int maxDeterminizedStates) { | ||
| public static Automaton toCaseInsensitiveChar(int codepoint, int maxDeterminizedStates) { |
There was a problem hiding this comment.
Wanted to use this, let me know if this shouldn't be that open. Another option is simpyl copying the logic over I think.
|
I'm working on backporting the case insensitive term/prefix/wildcard query support to 7.x here |
| @@ -139,7 +139,7 @@ public Query existsQuery(QueryShardContext context) { | |||
|
|
|||
| @Override | |||
| public Query prefixQuery(String value, MultiTermQuery.RewriteMethod method, boolean caseInsensitve, QueryShardContext context) { | |||
| return wildcardQuery(value + "*", method, context); | |||
| return wildcardQuery(value + "*", method, caseInsensitve, context); | |||
| } | |||
There was a problem hiding this comment.
Typo - missing i in Insensitive.
| @@ -244,7 +244,7 @@ public Query wildcardQuery(String value, MultiTermQuery.RewriteMethod method, bo | |||
| ); | |||
| } | |||
|
|
|||
| VersionFieldWildcardQuery query = new VersionFieldWildcardQuery(new Term(name(), value)); | |||
| VersionFieldWildcardQuery query = new VersionFieldWildcardQuery(new Term(name(), value), caseInsensitve); | |||
| QueryParsers.setRewriteMethod(query, method); | |||
|
@markharwood thanks for the review. Sure I'll wait for your backport to 7.x before backporting this PR then. |
|
@cbuescher The 7.x backport is merged now |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
…62754) This change adds support for the recently introduced case insensitivity flag for wildcard and prefix queries. Since version field values are encoded differently we need to adapt our own AutomatonQuery variation to add both cases if case insensitivity is turned on.
…62782) This change adds support for the recently introduced case insensitivity flag for wildcard and prefix queries. Since version field values are encoded differently we need to adapt our own AutomatonQuery variation to add both cases if case insensitivity is turned on.
This change adds support for the recently introduced case insensitivity flag for
wildcard and prefix queries. Since version field values are encoded differently we
need to adapt our own AutomatonQuery variation to add both cases if case insensitivity
is turned on.