[7.x] Allow metadata fields in the _source #62616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Configurable metadata field mappers in the _source * Changes to support metadata fields in _source Added test testDocumentContainsAllowedMetadataField() * Merged DocumentParserTests from master Fixed broken tests * Handle non string values * Allow metadata fields to parse values/objects/arrays/null * Removed MetadataFieldMapper.isAllowedInSource() method Delegated this functionality to MetadataFieldMapper.parse() * Fixed bug that caused tests to break * Cleanup parsing for existing metadata fields * Cleanup parsing for existing metadata fields * Remove doParse() method * Fix broken test * Lookup metadata mapper by name Instead of linear scan
csoulios
added
:Search Foundations/Mapping
|
Pinging @elastic/es-search (:Search/Mapping) |
|
@elasticmachine run elasticsearch-ci/2 |
romseygeek
added a commit
that referenced
this pull request
May 6, 2021
#62616 refactored how we deal with building mapping updates for delete operations against an empty index. In 7x, delete operations include a type as part of the operation UID, and this type needs to be resolved against mappings. In particular, the type _doc can mean either a type called _doc (the general case), or it can mean whatever type this index actually has. There are two code paths in IndexShard.applyDeleteOperation, one for empty mappings and one for the standard case; #62616 was resolving the type for the first code path, but not the second, which meant that some delete operations could be written to the translog with an incorrect type. This commit adds type resolution to the second code path as well. Fixes #72735
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #61590 to 7.x