Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust keep alive assertion in ShardSearchRequest #62582

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Adjust keep alive assertion in ShardSearchRequest #62582

merged 1 commit into from
Sep 17, 2020

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Sep 17, 2020

Relates #62184

@dnhatn dnhatn added >non-issue :Search/Search Search-related issues that do not fall into other categories v8.0.0 v7.10.0 labels Sep 17, 2020
@dnhatn dnhatn requested review from bpintea and jimczi September 17, 2020 18:05
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label Sep 17, 2020
jimczi
jimczi approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn
Copy link
Member Author

dnhatn commented Sep 17, 2020

Thanks Jim!

@dnhatn dnhatn merged commit cc070bf into elastic:master Sep 17, 2020
@dnhatn dnhatn deleted the adjust-keep-alive-assertion branch September 17, 2020 18:53
bpintea
bpintea reviewed Sep 17, 2020
View reviewed changes
Copy link
Contributor

@bpintea bpintea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

dnhatn added a commit that referenced this pull request Sep 17, 2020
@dnhatn
Adjust keep alive assertion in ShardSearchRequest (#62582)
0127b71 
Relates #62184
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpintea bpintea bpintea left review comments

@jimczi jimczi jimczi approved these changes

Assignees
No one assigned
Labels
>non-issue :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v7.10.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dnhatn @elasticmachine @bpintea @jimczi @jakelandis