Fix failure in AppendProcessorTests.testAppendingToListWithDuplicatesDisallowed #62385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danhermann
added
>test
|
Pinging @elastic/es-core-features (:Core/Features/Ingest) |
elasticmachine
added
the
Team:Data Management
dakrone
reviewed
Sep 15, 2020
| List<String> nonexistingValues = new ArrayList<>(); | ||
| for (int i = 0; i < nonexistingValuesSize; i++) { | ||
| boolean valueExists = true; | ||
| while (valueExists) { |
There was a problem hiding this comment.
This seems really confusing to me, I think we could do the same thing with:
int nonexistingValueSize = randomIntBetween(0, 10);
// generate n new values
Set<String> newValues = Stream.generate(() -> randomAlphaOfLengthBetween(1, 10)).limit(nonexistingValueSize).collect(Collectors.toSet());
// create a set using the new values, making sure there are no overlapping values already present in the existing values
Set<String> nonexistingValues = Sets.difference(newValues, new HashSet<>(existingValues));Using the while loop for this is a bit overkill, I think Sets makes it easier to avoid duplicates
There was a problem hiding this comment.
Thanks, @dakrone. I simplified the test as you suggested.
|
Thanks, @dakrone! |
danhermann
added a commit
to danhermann/elasticsearch
that referenced
this pull request
Oct 8, 2020
danhermann
added a commit
that referenced
this pull request
Oct 8, 2020
danhermann
added a commit
to danhermann/elasticsearch
that referenced
this pull request
Oct 20, 2020
danhermann
added a commit
that referenced
this pull request
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the test cases purported to test the appending of unique values to an existing list but the list of unique values to be appended was randomly generated and would occasionally contain values already in the list (see example test seed below). This fix ensures that the list of unique values never contains any values in the existing list.
Example of a test seed that would fail:
./gradlew ':modules:ingest-common:test' --tests "org.elasticsearch.ingest.common.AppendProcessorTests.testAppendingToListWithDuplicatesDisallowed" -Dtests.seed=AC5D435485DE7219