Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] allow_duplicates option for append processor #62336

Merged
merged 2 commits into from
Sep 15, 2020

Conversation

danhermann
Copy link
Contributor

Documents the allow_duplicates option added in #61916

@danhermann danhermann added >docs General docs changes :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v8.0.0 v7.10.0 labels Sep 14, 2020
@danhermann danhermann requested a review from jrodewig September 14, 2020 17:47
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Ingest)

@elasticmachine elasticmachine added Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team labels Sep 14, 2020
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left a suggestion, but feel free to disregard if wanted. Thanks!

Comment on lines 20 to 22
| `allow_duplicates` | no | true | When false, ignores any of the values to be
appended that are already present in the
target field.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reword for clarity.

Suggested change
| `allow_duplicates` | no | true | When false, ignores any of the values to be
appended that are already present in the
target field.
| `allow_duplicates` | no | true | If `false`, the processor does not append
values already present in the field.

@danhermann
Copy link
Contributor Author

Thanks, @jrodewig!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >docs General docs changes Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v7.10.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants