Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test DLS and FLS against runtime fields #61820

Conversation

javanna
Copy link
Member

@javanna javanna commented Sep 1, 2020

This PR introduces integration tests for Document level security with queries against runtime fields, as well as field level security used in combination with runtime fields.

Relates to #59332

@javanna javanna added >test Issues or PRs that are addressing/adding tests :Search/Search Search-related issues that do not fall into other categories labels Sep 1, 2020
@javanna javanna requested a review from nik9000 September 1, 2020 20:58
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label Sep 1, 2020
@javanna javanna mentioned this pull request Sep 1, 2020
30 tasks
" \"year\" : {\n" +
" \"type\" : \"runtime_script\", \n" +
" \"runtime_type\" : \"keyword\",\n" +
" \"script\" : \"emitValue(doc[\\\"date\\\"].value.substring(0,4))\"\n" +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/\\"/'` I think will work.

assertOK(adminClient().performRequest(indexDoc2));

Request indexDoc3 = new Request("PUT", "/fls/_doc/3");
indexDoc3.addParameter("refresh", "wait_for");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to wait_for a refresh, we can just do true, I think.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both work I guess

@javanna
Copy link
Member Author

javanna commented Sep 2, 2020

run elasticsearch-ci/packaging-sample-windows

@javanna javanna merged commit d9ca982 into elastic:feature/runtime_fields Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team >test Issues or PRs that are addressing/adding tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants