Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant symbol #61353

Merged
merged 2 commits into from
Sep 1, 2020
Merged

Remove redundant symbol #61353

merged 2 commits into from
Sep 1, 2020

Conversation

boicehuang
Copy link
Contributor

Remove redundant symbol in msearch

@astefan astefan added the :Search/Search Search-related issues that do not fall into other categories label Aug 20, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label Aug 20, 2020
cbuescher
cbuescher approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The fact that this works (not only in tests) is is an interesting find. I think in addition to merging this change in the test resource I will open an issue do discuss if we should remove this leniency at some point.

@cbuescher cbuescher self-assigned this Aug 31, 2020
@cbuescher
Copy link
Member

@elasticmachine test this please

@cbuescher cbuescher merged commit af58659 into elastic:master Sep 1, 2020
@cbuescher
Copy link
Member

@boicehuang thanks, I will backport to our active branches and open an issue to discuss if we want to catch this outside of tests.

cbuescher pushed a commit that referenced this pull request Sep 1, 2020
@boicehuang
Remove redundant symbol in msearch tests (#61353)
8fdd3d1
cbuescher pushed a commit that referenced this pull request Sep 1, 2020
@boicehuang
Remove redundant symbol in msearch tests (#61353)
45518b7
@cbuescher cbuescher mentioned this pull request Sep 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbuescher cbuescher cbuescher approved these changes

Assignees

@cbuescher cbuescher

Labels
:Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@boicehuang @elasticmachine @cbuescher @astefan