Enable cancellation for msearch requests #61337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>enhancement
:Search/Search
|
Pinging @elastic/es-search (:Search/Search) |
|
Thanks Jim! |
dnhatn
added a commit
that referenced
this pull request
Aug 19, 2020
Today multi-search requests are not cancellable because we create regular tasks instead of cancellable ones for them.
|
Now that msearch is cancellable, is the plan to make it possible to automatically cancel it on connection close, like search works? |
@javanna I think we should implement it as it will be a small/contained change with RestCancellableNodeClient. (Sorry, I did not see your PR #44494 that implements the cancellation for msearch till now). |
|
no worries @dnhatn it had stalled and I was not finding time to get back to it. Thanks for fixing. |
dnhatn
added a commit
that referenced
this pull request
Aug 21, 2020
dnhatn
added a commit
that referenced
this pull request
Aug 21, 2020
dnhatn
added a commit
that referenced
this pull request
Aug 24, 2020
dnhatn
added a commit
that referenced
this pull request
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today multi-search requests are not cancellable because we create regular tasks instead of cancellable ones for them.