Add the ScriptService to the field parser config #60933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes parsing runtime fields much simpler.
nik9000
added
the
:Search/Search
|
Pinging @elastic/es-search (:Search/Search) |
|
@romseygeek I've opened this one against the runtime fields branch which lets me verify that it solves my problems. If you like it I'd like to cherry pick it over to master and 7.x. |
romseygeek
approved these changes
Aug 10, 2020
| @@ -146,14 +150,21 @@ public DateFormatter getDateFormatter() { | |||
|
|
|||
| protected Function<String, SimilarityProvider> similarityLookupService() { return similarityLookupService; } | |||
|
|
|||
| /** | |||
| * The {@linkplain ScriptService} to compile scripts needs by the {@linkplain Mapper}. | |||
Sure! If we start to see a bunch of merge conflicts I might bring this up again! |
|
Thanks @romseygeek ! |
javanna
reviewed
Aug 14, 2020
| match: | ||
| animal: cow | ||
| - match: {hits.total.value: 1} | ||
| - match: {hits.hits.0._source.animal: cow} |
There was a problem hiding this comment.
I was wondering if it would be possible to have some other way of testing this besides a yaml test, a single node test would also be good I think
This was referenced Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes parsing runtime fields much simpler.
We'd initially resisted doing this but all of our other integration options
proved more troublesome.