-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong result when executing bulk requests with and without pipeline #60818
Conversation
Pinging @elastic/es-core-features (:Core/Features/Ingest) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gaobinlong, thanks for fixing this. I'll get it merged in for the next release.
@elasticmachine ok to test |
@elasticmachine update branch |
@gaobinlong, after running the tests on this one, it appears that one of the new tests (https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+pull-request-bwc/6187/testReport/junit/org.elasticsearch.backwards/MixedClusterClientYamlTestSuiteIT/test__p0_bulk_90_pipeline_One_request_has_pipeline_and_another_not_/) is failing. Could you take a look at that one? |
@danhermann, maybe because we have not done the backport, so the new yaml test executes failed when there is a mixed cluster. I'm not clear about how to handle this situation, maybe we can remove the new yaml test and only execute the newly added unit test ? |
@gaobinlong, ah, right. I was not paying attention to the fact that it was a backwards compatibility test that failed. If you will add the following lines (including indentation) to the
That will skip the mixed cluster tests for now and then after I backport the change for earlier releases, I'll change that so that the mixed cluster tests include that for the appropriate releases. |
@danhermann, I have done that, and all checks have passed yet. |
@gaobinlong, great, thank you! I'll get this merged and backported. |
@danhermann I think we can remove |
Finished the last backport to 7.x and removed "backport pending" label. |
Closes #60437 .
When executing bulk api, if one request has no ingest pipeline and others have ingest pipeline, then the response is not correct, that's because in
IngestService#executeBulkRequest()
method, the cursori
doesn't move to next if the request has no ingest pipeline.The main changes are:
IngestService#executeBulkRequest()
.