Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Include reference to AWS VPC endpoints in s3 repository docs. #60654

Merged
merged 5 commits into from
Aug 5, 2020
Merged

[DOCS] Include reference to AWS VPC endpoints in s3 repository docs. #60654

merged 5 commits into from
Aug 5, 2020

Conversation

fcofdez
Copy link
Contributor

@fcofdez fcofdez commented Aug 4, 2020

No description provided.

@fcofdez fcofdez added >docs General docs changes :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v8.0.0 Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. labels Aug 4, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore)

@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Aug 4, 2020
DaveCTurner
DaveCTurner reviewed Aug 4, 2020
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder, should we positively recommend setting up a gateway VPC endpoint to S3 rather than using the NAT instance?

(it's possible that these docs date back to before this was an option)

@fcofdez
Copy link
Contributor Author

fcofdez commented Aug 4, 2020

Yes, that might be a good advice as it can reduce costs on private networks.

@fcofdez fcofdez requested a review from DaveCTurner August 5, 2020 14:38
DaveCTurner
DaveCTurner reviewed Aug 5, 2020
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ looks good, I suggested some slightly different wording.

docs/plugins/repository-s3.asciidoc Outdated Show resolved Hide resolved
docs/plugins/repository-s3.asciidoc Outdated Show resolved Hide resolved
docs/plugins/repository-s3.asciidoc Outdated Show resolved Hide resolved
DaveCTurner
DaveCTurner approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fcofdez fcofdez merged commit 3c44fbd into elastic:master Aug 5, 2020
fcofdez added a commit to fcofdez/elasticsearch that referenced this pull request Aug 5, 2020
@fcofdez @vocatan @DaveCTurner
[DOCS] Include reference to AWS VPC endpoints in s3 repository docs.
af8591a 
Add VPC endpoint as the recommended way of connecting to s3 in private subnets

Backport of elastic#60654

Co-authored-by: Bill Mitchell <[email protected]>
Co-authored-by: David Turner <[email protected]>
@fcofdez
Copy link
Contributor Author

fcofdez commented Aug 5, 2020

Thanks for the review!

@fcofdez fcofdez mentioned this pull request Aug 5, 2020
Merged
fcofdez added a commit to fcofdez/elasticsearch that referenced this pull request Aug 5, 2020
@fcofdez @vocatan @DaveCTurner
[DOCS] Include reference to AWS VPC endpoints in s3 repository docs.
8b4597d 
Add VPC endpoint as the recommended way of connecting to s3 in private subnets

Backport of elastic#60654

Co-authored-by: Bill Mitchell <[email protected]>
Co-authored-by: David Turner <[email protected]>
fcofdez added a commit to fcofdez/elasticsearch that referenced this pull request Aug 5, 2020
@fcofdez @vocatan @DaveCTurner
[DOCS] Include reference to AWS VPC endpoints in s3 repository docs.
ff748ba 
Add VPC endpoint as the recommended way of connecting to s3 in private subnets

Backport of elastic#60654

Co-authored-by: Bill Mitchell <[email protected]>
Co-authored-by: David Turner <[email protected]>
fcofdez added a commit to fcofdez/elasticsearch that referenced this pull request Aug 5, 2020
@fcofdez @vocatan @DaveCTurner
[DOCS] Include reference to AWS VPC endpoints in s3 repository docs.
db8eda7 
Add VPC endpoint as the recommended way of connecting to s3 in private subnets

Backport of elastic#60654

Co-authored-by: Bill Mitchell <[email protected]>
Co-authored-by: David Turner <[email protected]>
This was referenced Aug 5, 2020
Merged
Merged
Merged
fcofdez added a commit that referenced this pull request Aug 5, 2020
@fcofdez @vocatan @DaveCTurner
[DOCS] Include reference to AWS VPC endpoints in s3 repository docs. (#…
f64e572 
…60753)

Add VPC endpoint as the recommended way of connecting to s3 in private subnets

Backport of #60654

Co-authored-by: Bill Mitchell <[email protected]>
Co-authored-by: David Turner <[email protected]>
fcofdez added a commit that referenced this pull request Aug 5, 2020
@fcofdez @vocatan @DaveCTurner
[DOCS] Include reference to AWS VPC endpoints in s3 repository docs. (#…
212ed21 
…60754)

Add VPC endpoint as the recommended way of connecting to s3 in private subnets

Backport of #60654

Co-authored-by: Bill Mitchell <[email protected]>
Co-authored-by: David Turner <[email protected]>
fcofdez added a commit that referenced this pull request Aug 5, 2020
@fcofdez @vocatan @DaveCTurner
[DOCS] Include reference to AWS VPC endpoints in s3 repository docs. (#…
3fca53f 
…60755)

Add VPC endpoint as the recommended way of connecting to s3 in private subnets

Backport of #60654

Co-authored-by: Bill Mitchell <[email protected]>
Co-authored-by: David Turner <[email protected]>
fcofdez added a commit that referenced this pull request Aug 5, 2020
@fcofdez @vocatan @DaveCTurner
[DOCS] Include reference to AWS VPC endpoints in s3 repository docs. (#…
d6ee39e 
…60756)

Add VPC endpoint as the recommended way of connecting to s3 in private subnets

Backport of #60654

Co-authored-by: Bill Mitchell <[email protected]>
Co-authored-by: David Turner <[email protected]>
@fcofdez fcofdez mentioned this pull request Aug 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaveCTurner DaveCTurner DaveCTurner approved these changes

Assignees
No one assigned
Labels
backport pending :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >docs General docs changes Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Team:Docs Meta label for docs team v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fcofdez @elasticmachine @DaveCTurner @jakelandis @vocatan