-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify remote clusters' use of transport layer #60268
Merged
DaveCTurner
merged 1 commit into
elastic:master
from
DaveCTurner:2020-07-28-clarify-remote-clusters-transport-config
Jul 29, 2020
Merged
Clarify remote clusters' use of transport layer #60268
DaveCTurner
merged 1 commit into
elastic:master
from
DaveCTurner:2020-07-28-clarify-remote-clusters-transport-config
Jul 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today there are a few places in the transport layer docs where we talk about communication between nodes _within a cluster_. We also use the transport layer for remote cluster connections, and these statements also apply there, but this is not clear from today's docs. This commit generalises these statements to make it clear that they apply to remote cluster connections too. It also adds a link from the docs on configuring TCP retries to the (deeply-buried) docs on preserving long-lived connections.
DaveCTurner
added
>docs
General docs changes
:Distributed Coordination/Network
Http and internode communication implementations
v8.0.0
v7.10.0
v7.9.1
labels
Jul 28, 2020
Pinging @elastic/es-docs (>docs) |
Pinging @elastic/es-distributed (:Distributed/Network) |
elasticmachine
added
Team:Docs
Meta label for docs team
Team:Distributed
Meta label for distributed team (obsolete)
labels
Jul 28, 2020
ywelsch
approved these changes
Jul 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
DaveCTurner
deleted the
2020-07-28-clarify-remote-clusters-transport-config
branch
July 29, 2020 12:01
DaveCTurner
added a commit
that referenced
this pull request
Jul 29, 2020
Today there are a few places in the transport layer docs where we talk about communication between nodes _within a cluster_. We also use the transport layer for remote cluster connections, and these statements also apply there, but this is not clear from today's docs. This commit generalises these statements to make it clear that they apply to remote cluster connections too. It also adds a link from the docs on configuring TCP retries to the (deeply-buried) docs on preserving long-lived connections.
DaveCTurner
added a commit
that referenced
this pull request
Jul 29, 2020
Today there are a few places in the transport layer docs where we talk about communication between nodes _within a cluster_. We also use the transport layer for remote cluster connections, and these statements also apply there, but this is not clear from today's docs. This commit generalises these statements to make it clear that they apply to remote cluster connections too. It also adds a link from the docs on configuring TCP retries to the (deeply-buried) docs on preserving long-lived connections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed Coordination/Network
Http and internode communication implementations
>docs
General docs changes
Team:Distributed
Meta label for distributed team (obsolete)
Team:Docs
Meta label for docs team
v7.9.1
v7.10.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today there are a few places in the transport layer docs where we talk
about communication between nodes within a cluster. We also use the
transport layer for remote cluster connections, and these statements
also apply there, but this is not clear from today's docs. This commit
generalises these statements to make it clear that they apply to remote
cluster connections too.
It also adds a link from the docs on configuring TCP retries to the
(deeply-buried) docs on preserving long-lived connections.